[AND-152] Fix missing floating window due to missing local track #1241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`, update `me` based on the `isLocal` if its null, use `collectAsStateWithLifecycle` on `me` flow
liviu-timar
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Fix the issues where the local track would be missing thus not showing the floating participant window.
🛠 Implementation details
meflow now also attempts to mapmebased on theisLocalflag instead of just the session id.onConnectedand starting theconnectRtcflow.🧪 Testing
How to reproduce (inconsistent):
After the fix, I haven't encountered the issue on the Pixel 7 anymore i.e. I did 10 cycles of the above steps and the floating video would always show.